Add option to purge config dir #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow I did not realize purge was off. @EvanKrall is there any reason not to purge for our use-case? @sorenh please make it purge by default. |
|
Done |
|
Ok, the only thing missing here is, you guessed it, a test for this new functionality. Can you give me a test that by default this directory is purge=>true, and if given this special param the folder is purge => false? Additionally the input should be validated. |
|
Done. ...and I officially hate spec's default behaviour of blowing away fixtures when tests pass. Geez, this took way too long. |
Conflicts: spec/classes/init_spec.rb
|
Super! |
solarkennedy
added a commit
that referenced
this pull request
Sep 27, 2014
Add option to purge config dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easy to manage service definitions with Puppet. When a service is removed, Puppet no longer generates the file and setting purge => true means it gets removed and then it disappears from consul.