Add sysconfig support for sysv

[dblessing]

Source /etc/sysconfig/consul, if present. This will allow users to override PID_FILE or LOG_FILE if they wish. Also, it will allow setting GOMAXPROCS. This is maybe the most important feature this provides because otherwise GOMAXPROCS defaults to 1, which is not recommended. If the user does not set GOMAXPROCS after this change, it will default to 2.

I don't believe managing /etc/sysconfig/consul is necessary within this module. It's not a required file for this to work and users can optionally manage that file in a profile or wrapper module.

[solarkennedy]

Yea, I saw we were not managing GOMAXPROCS the other day when I was looking at some upstream init stuff.

I disagree on managing the file. Managing the configuration of consul is definitely within the scope of this module.

[dblessing]

Ok, fair enough :) Managing the sysconfig file would be fine. One of the main reasons I didn't is because I wasn't sure how you would handle separating that out since other OS's/init systems won't use that.

[EvanKrall]

This module is already managing the init scripts, so we could ensure all the flavors of init script source /etc/default/consul.

[dblessing]

@EvanKrall that actually sounds like a great idea. With that in place we could make all the init scripts flat files and not have the template stuff to worry about - manage all via defaults.