Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-9821: Use resource detection processor #56

Merged
merged 2 commits into from
Jul 20, 2022
Merged

NH-9821: Use resource detection processor #56

merged 2 commits into from
Jul 20, 2022

Conversation

michalJakubis
Copy link
Contributor

Use resource detection processor in order to fill in host.id in all metrics

@michalJakubis michalJakubis requested a review from a team July 20, 2022 06:33
@michalJakubis michalJakubis requested a review from etichy as a code owner July 20, 2022 06:33
@michalJakubis michalJakubis force-pushed the feature/NH-9821-use-resourcesdetection branch from 649d0b5 to a6d4bf7 Compare July 20, 2022 06:37
@gantrior
Copy link
Contributor

Isn't the processor rely that the Otel Collector will run on given EC2/Azure resource? At least according to doc, EC2 and Azure detectors try to contact metadata API, which is some specific endpoint available from within the VM, but our Otel Collector does not run on VM's that we monitor

@michalJakubis michalJakubis merged commit 2c09f72 into master Jul 20, 2022
@michalJakubis michalJakubis deleted the feature/NH-9821-use-resourcesdetection branch July 20, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantrior gantrior gantrior approved these changes

@etichy etichy Awaiting requested review from etichy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalJakubis @gantrior