fix(Layout): convert boolean true/false for omits to the required "tr…

[Smef]

Query is typed with

{
    omit?: boolean
}

but it must actually be a string of "true" or "false". This updates the typing to allow those values, as well as to properly convert boolean values to the string format required for the query to the Data API.

[lart2150]

@DASPRiD it looks like FM is expecting a string for some reason. since it really should be a string should we change the type to

omit ?: 'true' | 'false';

so we don't need to do the extra mapping?

[Smef]

I think passing a boolean value makes sense from a JS perspective. It's much easier to think about it like that, rather than dealing with weird fm parameter requirements. My preference would be to use booleans, personally.

[DASPRiD]

I'd say, keep the parameter typing unchanged, but run query.omit.toString() to convert it to a boolean string. Something like:

query: (Array.isArray(query) ? query : [query]).map(query => ({
    ...query,
    omit: query.omit?.toString(),
})),

[Smef]

Sounds good. I've pushed those changes.

[DASPRiD]

That comment is quite redundant I'd say, think you can get rid of it :)

[Smef]

Done. I think it was explaining why before, but got trimmed out at some point

[github-actions]

🎉 This PR is included in version 1.3.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀