Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🤔 sd-teaser-media variant title alignment #1296

Closed
4 of 9 tasks
Tracked by #1375
MartaPintoTeixeira opened this issue Aug 16, 2024 · 4 comments
Closed
4 of 9 tasks
Tracked by #1375

fix: 🤔 sd-teaser-media variant title alignment #1296

MartaPintoTeixeira opened this issue Aug 16, 2024 · 4 comments
Assignees
@yoezlem
Labels
BREAKING CHANGE all issues which end up in a breaking change 🔧 code needs changes in code

Comments

@MartaPintoTeixeira
Copy link
Contributor

MartaPintoTeixeira commented Aug 16, 2024 •
edited by coraliefeil
Loading

Current behavior

Issues:
On storybook the variant "Gradient-light" is named "Gradient-white"

Expected behavior

Variant should be named "Gradient-light" as it is in FIGMA.

Steps to reproduce

https://solid-design-system.fe.union-investment.de/x.x.x/storybook/index.html?path=/docs/components-sd-teaser-media--docs

Technical Information

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@MartaPintoTeixeira MartaPintoTeixeira added the 🔧 code needs changes in code label Aug 16, 2024
@yoezlem yoezlem moved this from 🛠️ To be pre-refined to ⚙️ To be refined in Solid Design System Project Board Aug 16, 2024
@MartaPintoTeixeira MartaPintoTeixeira changed the title fix: 🤔 sd-teaser-media variant title update fix: 🤔 sd-teaser-media variant title and default variant update Aug 20, 2024
@karlbaumhauer karlbaumhauer added the BREAKING CHANGE all issues which end up in a breaking change label Sep 13, 2024
@karlbaumhauer
Copy link
Contributor

@coraliefeil pls check if the secondpoint is still valid.

@karlbaumhauer karlbaumhauer assigned coraliefeil and unassigned yoezlem Sep 13, 2024
@karlbaumhauer karlbaumhauer added the 🚧🛑🚧 waiting for DESIGN 🚧🛑🚧 DEV is done but waiting for Design to publish together label Sep 13, 2024
@karlbaumhauer karlbaumhauer moved this from ⚙️ To be refined to 🔖 Ready in Solid Design System Project Board Sep 13, 2024
@karlbaumhauer karlbaumhauer mentioned this issue Sep 13, 2024
Open
10 tasks
@coraliefeil coraliefeil changed the title fix: 🤔 sd-teaser-media variant title and default variant update fix: 🤔 sd-teaser-media variant title alignment Sep 16, 2024
@coraliefeil coraliefeil removed BREAKING CHANGE all issues which end up in a breaking change 🚧🛑🚧 waiting for DESIGN 🚧🛑🚧 DEV is done but waiting for Design to publish together labels Sep 16, 2024
@yoezlem yoezlem added the BREAKING CHANGE all issues which end up in a breaking change label Sep 17, 2024
@coraliefeil coraliefeil removed the BREAKING CHANGE all issues which end up in a breaking change label Sep 18, 2024
@coraliefeil
Copy link
Contributor

If we don’t change the default variant it is not a breaking change IMO @yoezlem that’s why I removed the label.

@mariohamann
Copy link
Contributor

It is a breaking change, as if someone set gradient-white in the past, this won't work anymore.

@mariohamann mariohamann added the BREAKING CHANGE all issues which end up in a breaking change label Sep 18, 2024
@coraliefeil
Copy link
Contributor

Ah ok. Understood. THX

@yoezlem yoezlem assigned yoezlem and unassigned coraliefeil Sep 19, 2024
@yoezlem yoezlem moved this from 🔖 Ready to 👀 In review in Solid Design System Project Board Sep 19, 2024
@yoezlem yoezlem closed this as completed Sep 25, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Sep 25, 2024
@yoezlem yoezlem reopened this Sep 25, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ⚙️ To be refined in Solid Design System Project Board Sep 25, 2024
@yoezlem yoezlem closed this as completed Sep 25, 2024
@github-project-automation github-project-automation bot moved this from ⚙️ To be refined to ✅ Done in Solid Design System Project Board Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoezlem yoezlem

Labels
BREAKING CHANGE all issues which end up in a breaking change 🔧 code needs changes in code
Projects
Solid Design System Project Board
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
8 participants
@mariohamann @coraliefeil @smfonseca @karlbaumhauer @Vahid1919 @auroraVasconcelos @yoezlem @MartaPintoTeixeira