Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🤔 Navigation-Item medium size name #1418

Open
9 tasks
Tracked by #1375
auroraVasconcelos opened this issue Sep 19, 2024 · 0 comments
Open
9 tasks
Tracked by #1375

fix: 🤔 Navigation-Item medium size name #1418

auroraVasconcelos opened this issue Sep 19, 2024 · 0 comments
Assignees
Labels
BREAKING CHANGE all issues which end up in a breaking change

Comments

@auroraVasconcelos
Copy link
Contributor

Current behavior

The medium size name for the sd-navigation-item is 'base'.

Expected behavior

In order to keep consistence with other components and with figma the expected value would be 'md'

Steps to reproduce

Link to storybook

Technical Information

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE all issues which end up in a breaking change
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants