Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[dev]: ✨ implement A11y improvements to sd-table and sd-table-cell #1507

Closed
1 of 9 tasks
Tracked by #1465
yoezlem opened this issue Oct 9, 2024 · 1 comment
Closed
1 of 9 tasks
Tracked by #1465
Labels
A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS 🔧 code needs changes in code Subtask Epic subtasks

Comments

@yoezlem
Copy link
Contributor

yoezlem commented Oct 9, 2024

Description

This task describes the Storybook implementation for the sd-table and sd-table-cell component as part of the A11y improvements outlined in Epic #1465.

A11y improvements for sd-table and sd-table-cell can be found here: sd-table and sd-table-cell Notes.


Comment

The default example doesn’t show a proper data table.

Open Questions

  • Question1
  • Question2

DoR

  • Item has been estimated by the team
  • Item dependencies have been identified and documented

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@yoezlem yoezlem added 🔧 code needs changes in code Subtask Epic subtasks labels Oct 9, 2024
@yoezlem yoezlem added the A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS label Oct 9, 2024
@coraliefeil coraliefeil moved this from 📋 Backlog to ⚙️ To be refined in Solid Design System Project Board Dec 6, 2024
@karlbaumhauer
Copy link
Contributor

changing this would make the code sample more complex => 10 lines of code but only 1 is important

@karlbaumhauer karlbaumhauer closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2024
@github-project-automation github-project-automation bot moved this from ⚙️ To be refined to ✅ Done in Solid Design System Project Board Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS 🔧 code needs changes in code Subtask Epic subtasks
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants