Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🤔 sd-text area help-text and error messages fixes #1647

Open
9 tasks
MartaPintoTeixeira opened this issue Nov 14, 2024 · 0 comments
Open
9 tasks

fix: 🤔 sd-text area help-text and error messages fixes #1647

MartaPintoTeixeira opened this issue Nov 14, 2024 · 0 comments
Assignees
Labels
🔧 code needs changes in code

Comments

@MartaPintoTeixeira
Copy link
Contributor

MartaPintoTeixeira commented Nov 14, 2024

Current behavior

Problems:
1 ) The margin between the help-text and the text area and the margin between the error message and the text area is not consistent. will create a ticket to solve this issue in both figma and dev.
2 ) Help-text is visible in all screenshots:
https://solid-design-system.fe.union-investment.de/docs/?path=/story/components-sd-textarea-screenshots-sd-textarea--default
3 ) Label not showing:
https://solid-design-system.fe.union-investment.de/docs/?path=/story/components-sd-textarea-screenshots-sd-textarea--combination

Expected behavior

Solution:
1 ) figma: change it to margin-top 4 - DONE #1662
code: use the same margin you use for "error messages" in sd-input
2 ) Hide help-text in all screenshots execpt for "validation"
3 ) Show label (it is mandatory)

Steps to reproduce

Technical Information

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@MartaPintoTeixeira MartaPintoTeixeira changed the title fix: 🤔 sd-text area margic fix for help-text and error message fix: 🤔 sd-text area margin fix for help-text and error message Nov 14, 2024
@MartaPintoTeixeira MartaPintoTeixeira added 🎨 figma needs changes in Figma 🔧 code needs changes in code labels Nov 14, 2024
@MartaPintoTeixeira MartaPintoTeixeira removed the 🎨 figma needs changes in Figma label Nov 19, 2024
@MartaPintoTeixeira MartaPintoTeixeira removed their assignment Nov 19, 2024
@yoezlem yoezlem moved this from 📋 Backlog to ⚙️ To be refined in Solid Design System Project Board Nov 28, 2024
@MartaPintoTeixeira MartaPintoTeixeira changed the title fix: 🤔 sd-text area margin fix for help-text and error message fix: 🤔 sd-text area help-text and error messages fixes Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 code needs changes in code
Projects
Status: ⚙️ To be refined
Development

No branches or pull requests

3 participants