Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript error when upgrading from solidjs 1.8.17 to 1.8.22 #44

Open
carcinocron opened this issue Sep 19, 2024 · 0 comments
Open

Typescript error when upgrading from solidjs 1.8.17 to 1.8.22 #44

carcinocron opened this issue Sep 19, 2024 · 0 comments

Comments

@carcinocron
Copy link

this is from github actions on a PR by dependabot attempting to auto-update solidjs.

tsc -p ./tsconfig.json --noEmit

Error: ../../node_modules/.pnpm/solid-bootstrap@1.0.20_solid-js@1.8.22/node_modules/solid-bootstrap/dist/esm/Dropdown.d.ts(6,18): error TS2320: Interface 'DropdownProps' cannot simultaneously extend types 'DropdownProps' and 'Omit<HTMLAttributes<HTMLElement>, "children" | "onSelect">'.
  Named property 'onToggle' of types 'DropdownProps' and 'Omit<HTMLAttributes<HTMLElement>, "children" | "onSelect">' are not identical.
Error: ../../node_modules/.pnpm/solid-bootstrap@1.0.[20](https://github.com/carcinocron/solid-simple-tactics/actions/runs/10934113871/job/30353650684?pr=329#step:7:21)_solid-js@1.8.22/node_modules/solid-bootstrap/dist/esm/Navbar.d.ts(4,18): error TS2430: Interface 'NavbarProps' incorrectly extends interface 'Omit<HTMLAttributes<HTMLElement>, "onSelect">'.
  Types of property 'onToggle' are incompatible.
    Type '((expanded: boolean) => void) | undefined' is not assignable to type 'EventHandlerUnion<HTMLElement, ToggleEvent> | undefined'.
      Type '(expanded: boolean) => void' is not assignable to type 'EventHandlerUnion<HTMLElement, ToggleEvent> | undefined'.
        Type '(expanded: boolean) => void' is not assignable to type 'EventHandler<HTMLElement, ToggleEvent>'.
          Types of parameters 'expanded' and 'e' are incompatible.
            Type 'ToggleEvent & { currentTarget: HTMLElement; target: Element; }' is not assignable to type 'boolean'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant