Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow down exceptions for avoid_returning_widgets #42

Closed
solid-yuriiprykhodko opened this issue Aug 11, 2023 · 1 comment
Closed

Narrow down exceptions for avoid_returning_widgets #42

solid-yuriiprykhodko opened this issue Aug 11, 2023 · 1 comment
Labels
custom_lints migration

Comments

@solid-yuriiprykhodko
Copy link
Collaborator

solid-yuriiprykhodko commented Aug 11, 2023 •
edited
Loading

https://github.com/solid-software/solid_lints/blob/release-v0.1.0/lib/lints/avoid_returning_widgets/avoid_returning_widgets_rule.dart#L30

image

We should narrow down the rule to allow Widget build() method only for Widget subclasses.

cc @n-bernat I think we overdid it with the refactoring :)
@solid-vovabeloded
Copy link
Collaborator

solid-vovabeloded commented Nov 10, 2023 •
edited
Loading

Closed, but created a follow-up issue to improve the behavior
#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
custom_lints migration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@solid-yuriiprykhodko @solid-vovabeloded