Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erd -p doesnotexist deadlocks, rejects ^C, and doesn't properly restore terminal #214

Closed
vincentdephily opened this issue Jul 1, 2023 · 2 comments · Fixed by #216
Closed

Comments

@vincentdephily
Copy link

Running erd -p doesnotexist anywhere prints Preparing output... and then just sits there forever, consuming no CPU. It also doesn't exit on a ^C. This can be worked around with a ^Z followed by a kill %1 but this leaves the terminal in a "cursor not visible" state, requiring an extra reset to get back to normal.

Running erg -p doesnotexist --no-progress immediately prints No entries to show with given arguments. and exits.

Expected:

  • erd -p doesnotexist should exit immediately.
  • Hitting ^C at any point during erd execution should work, and restore terminal settings.
@solidiquis
Copy link
Owner

Thanks for catching this. Shipping a patch immediately.

@solidiquis
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants