Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup should delte id too? #34

Open
Joeysantoro opened this issue Sep 23, 2024 · 1 comment
Open

Cleanup should delte id too? #34

Joeysantoro opened this issue Sep 23, 2024 · 1 comment

Comments

@Joeysantoro
Copy link

https://github.com/solidity-labs-io/safe-time-guard/blob/a70a7592226a39fb3d11c01a16ac369ff4051b52/src/Timelock.sol#L685

After cleanup on an expired operation, timestamp is still set so

  1. isOperationExpired is still true
  2. the assert statement can be hit on a second call to cleanup
  3. The specific id of the expired operation can no longer be called at all because schedule calls will fail and there is no way to delete the id anymore
@ElliotFriedman
Copy link
Contributor

The assert statement can be false, however, if a proposal expired, we wanted to keep a record of that, and if we deleted the timestamp, then there would not be a record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants