Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactivity: derived signals should be allowed as getters #18

Closed
otonashixav opened this issue Apr 12, 2022 · 1 comment
Closed

reactivity: derived signals should be allowed as getters #18

otonashixav opened this issue Apr 12, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@otonashixav
Copy link

Describe the bug
I note that the reactivity docs mention:

This rule ignores object and class methods completely. Solid is based on functions/closures only, and it's uncommon to see methods in Solid code.

However, with getters this is not the case. The docs suggest using getters as derived values in stores: https://www.solidjs.com/docs/latest/api#getters.

Expected behavior
Getter should not warn.

Screenshots
image

Additional context
Discord

@otonashixav otonashixav added the bug Something isn't working label Apr 12, 2022
@joshwilsonvu
Copy link
Collaborator

This is fixed in v0.4.7, thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants