Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solid/event-handlers doesn't correct onCLICK to onClick #26

Closed
joshwilsonvu opened this issue May 26, 2022 · 0 comments
Closed

solid/event-handlers doesn't correct onCLICK to onClick #26

joshwilsonvu opened this issue May 26, 2022 · 0 comments
Assignees
@joshwilsonvu
Labels
bug Something isn't working

Comments

@joshwilsonvu
Copy link
Collaborator

Describe the bug
For events with one-word names, getCommonEventHandlerName doesn't lowercase everything past the third letter, so onCLICK will slip through unchanged.

Expected behavior
Common events like onCLICK should be fixed to onClick.
@joshwilsonvu joshwilsonvu added the bug Something isn't working label May 26, 2022
@joshwilsonvu joshwilsonvu self-assigned this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshwilsonvu joshwilsonvu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshwilsonvu