Skip to content

[Bug?]: Type checking with @total-typescript/ts-reset fails #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
lirbank opened this issue Aug 16, 2023 · 3 comments
Closed
2 tasks done

[Bug?]: Type checking with @total-typescript/ts-reset fails #1008

lirbank opened this issue Aug 16, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@lirbank
Copy link

lirbank commented Aug 16, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

Type checking SolidStart with https://www.npmjs.com/package/@total-typescript/ts-reset fails.

Expected behavior 🤔

Type check should pass.

Steps to reproduce 🕹

Steps:

  1. npm init solid@latest
  2. npm install
  3. npm install @total-typescript/ts-reset
  4. Create a reset.d.ts file in your project with these contents (see https://www.npmjs.com/package/@total-typescript/ts-reset#user-content-get-started):
// Do not add any other lines of code to this file!
import "@total-typescript/ts-reset";
  1. npx tsc --noEmit

Context 🔦

The https://www.npmjs.com/package/@total-typescript/ts-reset package has some very useful better default types for some common functions. I use it in all my projects, it would be epic if it worked with SolidStart too.

Your environment 🌎

No response

@lirbank lirbank added the bug Something isn't working label Aug 16, 2023
@lirbank lirbank changed the title [Bug?]: @total-typescript/ts-reset and SolidStart fail type checking [Bug?]: Type checking with @total-typescript/ts-reset fails Aug 16, 2023
@lirbank
Copy link
Author

lirbank commented Aug 16, 2023

Related to #976

@lirbank
Copy link
Author

lirbank commented Aug 16, 2023

In the meantime, here is a nice workaround:
#255 (comment)

For me this file list works:

const FILES = [
  "node_modules/solid-start/api/router.ts",
  "node_modules/solid-start/data/createRouteAction.tsx",
  "node_modules/solid-start/data/Form.tsx",
  "node_modules/solid-start/islands/mount.tsx",
  "node_modules/solid-start/islands/router.ts",
  "node_modules/solid-start/islands/server-router.tsx",
  "node_modules/solid-start/server/middleware.ts",
  "node_modules/solid-start/server/server-functions/server.ts",
  "node_modules/solid-start/session/cookie.ts",
  "node_modules/solid-start/session/cookies.ts",
];

@ryansolid
Copy link
Member

In setting up for SolidStart's next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See #1139 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants