Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying host "code.local" causes crashing #1054

Closed
2 tasks done
jcalfee opened this issue Sep 8, 2023 · 2 comments
Closed
2 tasks done

Specifying host "code.local" causes crashing #1054

jcalfee opened this issue Sep 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jcalfee
Copy link

jcalfee commented Sep 8, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

$ HOST=code.local npm run dev

 version  0.3.5
 adapter  node

  VITE v4.4.9  ready in 499 ms

  ➜  Network: http://code.local:3037/
  ➜  Inspect: http://localhost:3037/__inspect/
  ➜  press h to show help
file:///home/james/dev/ipall/ssweb/node_modules/.pnpm/solid-start@0.3.5_@solidjs+meta@0.28.6_@solidjs+router@0.8.3_solid-js@1.7.11_solid-start-node@0.3.5_vite@4.4.9/node_modules/solid-start/vite/plugin.js:243
              printUrls(config.solidOptions.router, url.substring(0, url.length - 1));
                                                        ^

TypeError: Cannot read properties of undefined (reading 'substring')
    at Timeout._onTimeout (file:///home/james/dev/ipall/ssweb/node_modules/.pnpm/solid-start@0.3.5_@solidjs+meta@0.28.6_@solidjs+router@0.8.3_solid-js@1.7.11_solid-start-node@0.3.5_vite@4.4.9/node_modules/solid-start/vite/plugin.js:243:57)
    at listOnTimeout (node:internal/timers:564:17)
    at process.processTimers (node:internal/timers:507:7)

Node.js v18.12.1
import solid from "solid-start/vite"
import { defineConfig } from "vite"

export default defineConfig({
  plugins: [solid()],
  server: {
    host: process.env.HOST ?? 'localhost',
    port: process.env.PORT ?? 3037
  }
})

Expected behavior πŸ€”

No crashing and working

Steps to reproduce πŸ•Ή

Steps:

  1. see above

Context πŸ”¦

No response

Your environment 🌎

No response

@jcalfee jcalfee added the bug Something isn't working label Sep 8, 2023
@emdede
Copy link
Contributor

emdede commented Sep 23, 2023

Should be fixed after #1057. Can you check it with latest version (0.3.6)?

@jcalfee
Copy link
Author

jcalfee commented Sep 23, 2023

Confirmed, it works. Thank you!

@jcalfee jcalfee closed this as completed Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants