Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Broken vite config in websocket template #1075

Closed
2 tasks done
ronanru opened this issue Oct 1, 2023 · 1 comment
Closed
2 tasks done

[Bug?]: Broken vite config in websocket template #1075

ronanru opened this issue Oct 1, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ronanru
Copy link

ronanru commented Oct 1, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

I generated a project with websocket template and no ssr. In the generated vite.config.ts the ssr option is included twice.

export default defineConfig({
  plugins: [
    solid({
      ssr: false,
      ssr: true, // <--------------
      experimental: {
        websocket: true,
      },
      adapter: startCloudflareWorkers({
        durableObjectsPersist: true,
        kvPersist: false,
      }),
    }),
  ],
});

Expected behavior 🤔

No response

Steps to reproduce 🕹

image

Context 🔦

No response

Your environment 🌎

No response

@ronanru ronanru added the bug Something isn't working label Oct 1, 2023
@ryansolid
Copy link
Member

In setting up for SolidStart's next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See #1139 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants