Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Update @rollup/plugin-commonjs to fix shebangs #1136

Closed
2 tasks done
JesseVelden opened this issue Dec 7, 2023 · 1 comment
Closed
2 tasks done

[Bug?]: Update @rollup/plugin-commonjs to fix shebangs #1136

JesseVelden opened this issue Dec 7, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@JesseVelden
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

When I try to build, I get the following error from Rollup, trying to build an external dependency which has a shebang at the top of the file:

Error [RollupError]: Unexpected character '!'
...
frame: '1: #!/usr/bin/env node\n' ,
pluginCode: 'PARSE_ERROR',
plugin: 'commonjs--resolver',
...

Expected behavior 🤔

To build successfully

Steps to reproduce 🕹

No response

Context 🔦

It seems to be recently fixed in Rollup: rollup/plugins#1610.
Can we update to the latest @rollup/plugin-common-js version?

Also related to update Vite/ Rollup: #1123

Your environment 🌎

No response

@JesseVelden JesseVelden added the bug Something isn't working label Dec 7, 2023
@ryansolid
Copy link
Member

plugin-common-js was causing really weird build issues which is why it is on an old version. That being said this all has been replaced in the next beta.

In setting up for SolidStart's next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See #1139 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants