Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: onig.wasm from shikiji in build output #1281

Closed
2 tasks done
edivados opened this issue Jan 24, 2024 · 4 comments
Closed
2 tasks done

[Bug?]: onig.wasm from shikiji in build output #1281

edivados opened this issue Jan 24, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@edivados
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

onig.wasm from shikiji is emitted as asset in build.

Expected behavior 🤔

No onig.wasm in build output.

Steps to reproduce 🕹

Look at terminal output at the end.

Open in StackBlitz

Steps:

  1. pnpm create solid
  2. select basic/ts/ssr
  3. pnpm run build
  4. go to .output/public/_build/assets (there is a .wasm file)

Context 🔦

No response

Your environment 🌎

No response

@edivados edivados added the bug Something isn't working label Jan 24, 2024
@ryansolid
Copy link
Member

I see.. good catch. I was so concerned with it tree shaking in the browser (which it does), I didn't see that it made it into the assets. Not sure what we will do here but good to know.

@edivados
Copy link
Contributor Author

Ok. Looks like I can remove it from the bundle for now.

@lxsmnsyc lxsmnsyc self-assigned this Jan 25, 2024
@ryansolid
Copy link
Member

@lxsmnsyc or @nksaraf any thoughts on this?

@edivados
Copy link
Contributor Author

No wasm file in 0.7.5. I guess this was fixed in 0.7.3 by #1373
Thanky you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants