[Bug?]: Rejected promises in server fns are not handled correctly

[marvin-j97]

Duplicates

• I have searched the existing issues

Latest version

• I have tested the latest version

Current behavior 😯

This is similar but not the same as #1222
Here's a simple reproduction:

import { cache, createAsync } from "@solidjs/router";

const myFn = cache(async () => {
  "use server";

  await Promise.reject("oh no");

  return "Halló";
}, "myFn");

export default function Home() {
  const msg = createAsync(() => myFn(), {
    deferStream: true
  });

  return (
    <main>
      <h1>{msg()} world!</h1>
    </main>
  );
}

On initial SSR, Dev server crashes with Error: oh no, but should probably show an error page, and log something in the console, but not die.

When using client-side routing (going from /about to /broken page), an error is printed:

Uncaught (in promise) SyntaxError: Unexpected identifier 'no'
    at eval (<anonymous>)
    at deserialize (index.mjs?v=7b36de8d:3200:19)
    at SerovalChunkReader.next (server-runtime.ts?v=7b36de8d:43:14)
    at SerovalChunkReader.next (server-runtime.ts?v=7b36de8d:30:25)
    at async deserializeStream (server-runtime.ts?v=7b36de8d:60:18)

Seemingly, rejections are not taken into account correctly. Again, a pop-up telling the user a fatal error in the server function occured would be great.

Steps to reproduce 🕹

See example

Context 🔦

Obvious

Your environment 🌎

• Using latest basic solid-cli example as of today
• Chrome
• Ubuntu

[lxsmnsyc]

probably has something to do with cache 🤔

does it work normally without it?

[marvin-j97]

probably has something to do with cache 🤔

does it work normally without it?

No.

CSR routing:

Error: Unknown error
    at castError (chunk-VFKAEII7.js?v=c4b37483:979:10)
    at chunk-VFKAEII7.js?v=c4b37483:364:79

SSR, crashes:

Error: oh no

[lxsmnsyc]

Okay thanks! for the _server, can you show me what does the response look like?

[marvin-j97]

Okay thanks! for the _server, can you show me what does the response look like?

oh no

(literally)

[marvin-j97]

@lxsmnsyc Without using cache:

{
  "statusCode": 500,
  "stack": []
}

[lxsmnsyc]

Just realized that this is the cause of the issue

solid-start/packages/start/config/server-handler.ts

Line 171 in f787f2b

if (!result || typeof result === "string") return result || null;

it was not following the expected format for the deserializer. Will fix.