Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Starting a new solidStart application with npm produces an application that can't target Cloudflare Pages #1357

Closed
2 tasks done
dario-piotrowicz opened this issue Mar 1, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@dario-piotrowicz
Copy link

dario-piotrowicz commented Mar 1, 2024

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

When I run npm create-solid@latest the CLI produces an application that, when using the cloudflare-pages preset can't be deployed on Cloudflare Pages.

Trying to run the application via wrangler pages dev or deploy it via wrangler pages deploy produces the following error:
Screenshot 2024-03-01 at 17 48 00

PS: this seems to be a regression as this error was present before, fixed and now has come back, see: #1217

Expected behavior 🤔

The generated application should be deployable to Cloudflare Pages.

Steps to reproduce 🕹

Steps:

  1. run npx create-solid@latest
  2. choose to create a solid-start project
  3. run cd <your-solid-project>
  4. run npm install
  5. run SERVER_PRESET=cloudflare-pages npm run build
    (instead of using SERVER_PRESET you can update the app.config.(js/ts) file accordingly)
  6. run npx wrangler pages dev dist/
  7. see the error in the terminal
Screenshots of my terminal when running the above steps

solid1

solid2

solid3

Context 🔦

Note

this seems to only happen with npm, I did try pnpm and it didn't present the same issue

Your environment 🌎

macOs Sonoma 14.3.1
npm: 9.5.1
node: 18.16.0
@ryansolid
Copy link
Member

Yeah this has to do with package resolution I think. I locked the vinxi in the examples to fix a bug but not in start itself and it must not match up properly causing the issue. Now that I've unlocked again I'm hoping this is fixed..

@dario-piotrowicz
Copy link
Author

@ryansolid I just tried creating a brand new solidStart app and the issue seems to be gone!

Thanks a bunch! ❤️

I'm closing the issue then 🙂👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants