Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Button type attribute has not been set. in templates #1517

Closed
2 tasks done
hamirmahal opened this issue May 28, 2024 · 0 comments · Fixed by #1518
Closed
2 tasks done

[Bug?]: Button type attribute has not been set. in templates #1517

hamirmahal opened this issue May 28, 2024 · 0 comments · Fixed by #1518
Labels
bug Something isn't working

Comments

@hamirmahal
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

Default templates don't specify the type of a button, which is problematic because the default type is submit, not "button", which users may not expect.

Expected behavior 🤔

Templates should specify type="button".

Steps to reproduce 🕹

Steps:

  1. npm init solid@latest
  2. Select with-vitest as a template or any other option that uses a button without specifying its type attribute.

Context 🔦

Ideally, new projects should be free of any errors and linting issues. It's one less thing to do for people who are trying to create a Solid project.

Your environment 🌎

No response

@hamirmahal hamirmahal added the bug Something isn't working label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant