Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling dev option does nothing #62

Open
thetarnav opened this issue Oct 6, 2022 · 2 comments
Open

Disabling dev option does nothing #62

thetarnav opened this issue Oct 6, 2022 · 2 comments

Comments

@thetarnav
Copy link

I imagine that putting { dev: false } should prevent vite from loading the development runtime of solid, and load production instead. This doesn't seem to be happening though.

Simple repro: (the DEV object logged to console shouldn't have those functions available)
https://stackblitz.com/edit/github-z6ct5t?file=src%2Findex.tsx,vite.config.ts

@ryansolid
Copy link
Member

Hmm.. vite seems to be doing this themselves even when we don't pass development as a condition to the compiler.

@aminya
Copy link
Contributor

aminya commented Jan 24, 2023

I have also faced the same problem with Solid Start. The bundle size is increased by 35 Kb and 560 ms of startup time because of this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants