Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logic of fallback functions into an internal named function #222

Open
Lumyo opened this issue Jun 26, 2023 · 2 comments · May be fixed by #226
Open

Move logic of fallback functions into an internal named function #222

Lumyo opened this issue Jun 26, 2023 · 2 comments · May be fixed by #226

Comments

@Lumyo
Copy link
Contributor

Lumyo commented Jun 26, 2023

I've had a case where I had to override the fallback function of Proxy.sol.
As there is no way to call super for a fallback function override, I had to copy/paste the logic in the override.
If the whole logic of the fallback function was instead in a named internal function, the override could directly call the internal function instead of having to duplicate the whole logic.
@ItsNickBarry
Copy link
Member

Is this related to the non-reentrant proxies that I discussed with @0xCourtney?

@Lumyo
Copy link
Contributor Author

Lumyo commented Jun 26, 2023

@ItsNickBarry Yes it is

@0xCourtney 0xCourtney linked a pull request Jul 28, 2023 that will close this issue
Move delegatecall logic from fallback function #226
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move delegatecall logic from fallback function solidstate-network/solidstate-solidity
2 participants
@ItsNickBarry @Lumyo