Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace discounted_amount with total_before_tax #31

Closed
DanielePalombo opened this issue Jun 23, 2023 · 2 comments
Closed

Replace discounted_amount with total_before_tax #31

DanielePalombo opened this issue Jun 23, 2023 · 2 comments

Comments

@DanielePalombo
Copy link
Collaborator

DanielePalombo commented Jun 23, 2023 •
edited
Loading

In solidus 2.4 discounted_amount has been deprecated in favor of total_before_tax.

ref solidusio/solidus@5d61419
@DanielePalombo
Copy link
Collaborator Author

Probably we could fix this specific issue but maybe we could have other issue in the future, so it's best to completely remove it. WDYT?

cc @DanielePalombo

@DanielePalombo
Copy link
Collaborator Author

Is not possible to detect the Class of the variable.

@DanielePalombo DanielePalombo closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
@DanielePalombo DanielePalombo mentioned this issue Aug 7, 2023
Open
@safafa safafa mentioned this issue Nov 24, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanielePalombo