Merge pull request #2814 from jtapia/chore/move_admin_reports

Move reports from backend into an extension

Author: kennyadsl

backend/app/controllers/spree/admin/reports_controller.rb

@@ -10,7 +10,6 @@ class BackendConfiguration < Preferences::Configuration
     PRODUCT_TABS       ||= [:products, :option_types, :properties,
                             :variants, :product_properties, :taxonomies,
                             :taxons]
-    REPORT_TABS        ||= [:reports]
     CONFIGURATION_TABS ||= [:stores, :tax_categories,
                             :tax_rates, :zones,
                             :payment_methods, :shipping_methods,
@@ -85,11 +84,6 @@ def menu_items
           condition: -> { can?(:admin, Spree::Product) },
           partial: 'spree/admin/shared/product_sub_menu'
         ),
-        MenuItem.new(
-          REPORT_TABS,
-          'file',
-          condition: -> { can?(:admin, :reports) },
-        ),
         MenuItem.new(
           CONFIGURATION_TABS,
           'wrench',

backend/app/models/spree/backend_configuration.rb

@@ -141,13 +141,6 @@
       end
     end
 
-    resources :reports, only: [:index] do
-      collection do
-        get :sales_total
-        post :sales_total
-      end
-    end
-
     resources :reimbursement_types, only: [:index]
     resources :adjustment_reasons, except: [:show, :destroy]
     resources :refund_reasons, except: [:show, :destroy]

backend/app/views/spree/admin/reports/index.html.erb

@@ -23,10 +23,6 @@
         expect(page).to have_link("Products", href: "/admin/products", count: 2)
       end
 
-      it "should have a link to reports" do
-        expect(page).to have_link("Reports", href: "/admin/reports")
-      end
-
       it "should have a link to configuration" do
         expect(page).to have_link("Settings", href: "/admin/stores")
       end
@@ -84,7 +80,6 @@
       expect(page).to have_link('Orders')
       expect(page).not_to have_link('Products')
       expect(page).not_to have_link('Promotions')
-      expect(page).not_to have_link('Reports')
       expect(page).not_to have_link('Settings')
     end
   end