RFC: Taxation without adjustments #4613
mamhoff
started this conversation in
New Features or Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently, we use the
Spree::Adjustment
model to save taxation data on line items, shipments and orders.Adjustments have issues:
source
and are recalculated every time the order changes. For taxation, that's not so desirable as we are moving towards doing taxation for the order all in one go.Here's a proposal: Add a new thing called
Spree::Tax
that works just like an adjustment, except that it is somehow translatable throughI18n
, cannot be used for promotions, and is tied to aSpree::Shipment
exclusively.If line items need taxation, they can have a line item tax estimate, too - as a separate model.
Beta Was this translation helpful? Give feedback.
All reactions