Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Pricing TODO #1167

Closed
1 of 4 tasks
jhawthorn opened this issue May 19, 2016 · 3 comments
Closed
1 of 4 tasks

Admin Pricing TODO #1167

jhawthorn opened this issue May 19, 2016 · 3 comments
Milestone

Comments

@jhawthorn
Copy link
Contributor

jhawthorn commented May 19, 2016

#1117 introduced a new interface for editing prices. Obviously editing prices is important, so we should try to make the interface as good as possible.

Some immediate suggestions:

  • Validate entered currency (it's possible currently to make a price in an invalid currency, ex. "XYZ") Validate currency on Spree::Price #1169
  • Grouping common prices (@Dkendal and @Mandily did some investigation of this)
  • We have the master price both on the main product page as well as the pricing page. This will probably be cause of some confusion.
  • Showing "Master Variant" in the pricing table feels like we're leaking an implementation detail
@mamhoff
Copy link
Contributor

mamhoff commented May 20, 2016

#1169 should fix the first issue. I've also amended the #1117 to use a select2 instead of a text box for input.

@Mandily
Copy link
Contributor

Mandily commented May 24, 2016

I'd like to add two things to the to do list. The first one may solve @jhawthorn's last point above.

  • Pull the master variant pricing and cost price off of the main product page, and out of the variant table to an area all it's own at the top of the page.

This would also include a new feature I'd like to start implementing in the back end which is tooltips for more information. Great information for newbies, totally unneeded and thus out of the way for the experienced users.

move master variant

- [ ] Add an option types summary area at the top of the page so that the user can tell at a quick glance what's being used in the table below. I suspect the table could get messy at times, and a quick snapshot of what they're working with would be handy. This should fit to the right of the master variant pricing.

option types summary

@jhawthorn
Copy link
Contributor Author

We've made progress, as can be seen in the linked merged issues.

There's always going to be more we can do to improve the UI here, and this issue no longer has actionable steps forward.

Marking this done. Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants