Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reports to their own gem #1262

Closed
isaacfreeman opened this issue Jun 22, 2016 · 2 comments
Closed

Move reports to their own gem #1262

isaacfreeman opened this issue Jun 22, 2016 · 2 comments

Comments

@isaacfreeman
Copy link

Working on PR #1250 prompted a discussion with @dhonig, wherein we agreed that having reports in Solidus is a two-edged sword. It's pretty easy to write a report that chews up all available resources and degrades performance on the same server that's serving the front end to customers. On the other hand, the convenience of having reports right there in Solidus Admin is valuable for many merchants.

It would be good to encourage developers to make a conscious decision about how reports should be provided for each client. Moving them out of the main Solidus distribution into a separate gem would provide that decision point.

@jhawthorn
Copy link
Contributor

jhawthorn commented Jun 28, 2016

This makes sense to me. The builtin reports section has been stagnant for a long time (at least before #1250, which looks great). Moving them to a gem I hope would allow for making faster and more opinionated changes.

I'm sure there are more "common" reports we could share in an extension which are desirable across many stores. Some stores will also use external services to do their reporting, and may prefer this tab removed.

@jacobherrington
Copy link
Contributor

#2814 will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants