Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cart total/subtotal background color configurable #2251

Closed
mamhoff opened this issue Oct 4, 2017 · 2 comments
Closed

Make cart total/subtotal background color configurable #2251

mamhoff opened this issue Oct 4, 2017 · 2 comments

Comments

@mamhoff
Copy link
Contributor

mamhoff commented Oct 4, 2017

As identified by @akihitoalextsuboi in #1708, we have a hardcoded color variable for the background of the cart subtotal and total. We should change this to be a configurable, well-named variable.

A good variable name would be $cart-total-background-color.
@mamhoff mamhoff mentioned this issue Oct 4, 2017
Closed
@kennyadsl
Copy link
Member

It should also probably take into account $product_price_text_color now.

@gregdaynes
Copy link

I'll look into this later today.

@gregdaynes gregdaynes mentioned this issue Oct 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregdaynes @kennyadsl @mamhoff