Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non Eligible Order Adjustments Showing in Admin Order Cart Page #2484

Closed
skukx opened this issue Jan 3, 2018 · 2 comments
Closed

Non Eligible Order Adjustments Showing in Admin Order Cart Page #2484

skukx opened this issue Jan 3, 2018 · 2 comments

Comments

@skukx
Copy link
Contributor

skukx commented Jan 3, 2018 •
edited
Loading

Steps to reproduce

  • Go To Admin
  • Create a promotion with name 50% Off and exactly mimics the below settings

screen shot 2018-01-03 at 1 28 02 pm

  • Go to Orders
  • Create a new Order
  • Add an item that the promotion won't apply to

Expected behavior

Under Order Adjustments, The 50% Off promotion should not appear since it isn't eligible for the order.

Actual behavior

The 50% Off promotion appears under Order Adjustments even though eligible is false.
screen shot 2018-01-03 at 1 33 16 pm

System configuration

Solidus 2.3
@jacobherrington
Copy link
Contributor

I am able to replicate this issue.
Not sure why it happens. Looking into it now.

@skukx
Copy link
Contributor Author

skukx commented Jun 14, 2018

@jacobherrington I looked into it a while ago. I believe it is an easy fix, just a scoping issue

@jacobherrington jacobherrington mentioned this issue Sep 24, 2018
Closed
@coorasse coorasse mentioned this issue Apr 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a bug causing non-eligible adjustments to appear in the the admin… jacobherrington/solidus
3 participants
@kennyadsl @skukx @jacobherrington