You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Order#record_ip_address shouldn't risk blocking the request in case a validation check is not met. Instead of update_attributes! I'd suggest using update_column.
Solidus Version:
Found in 2.4, latest code seems to behaving the same way.
To Reproduce
Hard to reproduce, but got notifications for exceptions due to the validation on email.
Current behavior
Raises an exception if the order is invalid.
Expected behavior
No unrelated exceptions raised when recording the ip.
That PR's commit message is Avoid running validations in current_order but I think it refers to running validation only when we need to update the order - if IP is not changed it won't.
At the moment I can't see any cons skipping validation there. So 👍 for me!
Order#record_ip_address
shouldn't risk blocking the request in case a validation check is not met. Instead ofupdate_attributes!
I'd suggest usingupdate_column
.Solidus Version:
Found in 2.4, latest code seems to behaving the same way.
To Reproduce
Hard to reproduce, but got notifications for exceptions due to the validation on email.
Current behavior
Raises an exception if the order is invalid.
Expected behavior
No unrelated exceptions raised when recording the ip.
Additional context
related: #2068
The text was updated successfully, but these errors were encountered: