Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL on fonts.googleapis.com #4217

Closed
jarednorman opened this issue Nov 29, 2021 · 5 comments · Fixed by #4210, #4211 or #4212
Closed

SSL on fonts.googleapis.com #4217

jarednorman opened this issue Nov 29, 2021 · 5 comments · Fixed by #4210, #4211 or #4212

Comments

@jarednorman
Copy link
Member

We need to use SSL to access font.googleapis.com. Requests using regular HTTP no longer work.

There are current three PRs open that cover this for the support versions (thanks @RyanofWoods!):

As I noted here, we may want to backport that to even more versions as this is liable to break specs on any extensions that still support older versions and run feature specs.

@Noah-Silvera has volunteered to do at least v2.9 and v2.10 which she needs for our TaxJar extension if we're happy to merge the fixes into unsupported versions.

@jarednorman
Copy link
Member Author

@Noah-Silvera You've got the go-ahead to PR those older versions.

@jarednorman
Copy link
Member Author

We won't need to release new versions of those unsupported versions, since simply merging fixes should resolve CI issues you're seeing.

@waiting-for-dev
Copy link
Contributor

waiting-for-dev commented Dec 2, 2021

I already merged the one for 2.10. As I think it's the only one needed, I'm going to close it. Thanks for working on it!

@waiting-for-dev
Copy link
Contributor

Oh, I just saw a PR for 2.9. Reopening!!

@kennyadsl
Copy link
Member

Closing, we are not supporting 2.9 anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants