-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL on fonts.googleapis.com #4217
Comments
This was
linked to
pull requests
Nov 29, 2021
@Noah-Silvera You've got the go-ahead to PR those older versions. |
We won't need to release new versions of those unsupported versions, since simply merging fixes should resolve CI issues you're seeing. |
I already merged the one for 2.10. As I think it's the only one needed, I'm going to close it. Thanks for working on it! |
Oh, I just saw a PR for 2.9. Reopening!! |
Closing, we are not supporting 2.9 anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to use SSL to access font.googleapis.com. Requests using regular HTTP no longer work.
There are current three PRs open that cover this for the support versions (thanks @RyanofWoods!):
As I noted here, we may want to backport that to even more versions as this is liable to break specs on any extensions that still support older versions and run feature specs.
@Noah-Silvera has volunteered to do at least v2.9 and v2.10 which she needs for our TaxJar extension if we're happy to merge the fixes into unsupported versions.
The text was updated successfully, but these errors were encountered: