Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabs to replace right side nav #633

Closed
Mandily opened this issue Dec 30, 2015 · 8 comments
Closed

Add tabs to replace right side nav #633

Mandily opened this issue Dec 30, 2015 · 8 comments

Comments

@Mandily
Copy link
Contributor

Mandily commented Dec 30, 2015

Third level navigation currently exists in a vertical list on the right side of pages that belong to specific products, orders, and users.

I'd like to move that type of navigation into tabs at the top of the page where it will be more accessible and easier to click on. It will also free up some space horizontally so that we can expand tables that would be more helpful with additional columns.

One thing to note is that in doing this, we won’t be using the title from the right side nav in the tabs.

This would hopefully be implemented in the same release as a 100% width issue, so the tabs should expand across the full width of the content area of the page. If it made it into a release before the 100% width, we could just fit the tabs within the fixed width we have now.

tabs

There are two options for what would happen if there were too many tabs to fit on the screen.

  1. Add a horizontal scrollbar to the bottom of the screen
  2. Add a dropdown to select the other tabs

tabs dropdown menu

My preference is adding a dropdown to select the other tabs, but I'd like to hear what the community thinks.

@tvdeyen
Copy link
Member

tvdeyen commented Dec 30, 2015

Great. Far better, then current state of third level nav.

I also prefer the dropdown navigation for tabs not fitting the screen 👍

@Mandily I don't understand what you mean with:

One thing to note is that in doing this, we won’t be using the title from the right side nav in the tabs

What title? The text inside the link we have now?

@Mandily
Copy link
Contributor Author

Mandily commented Dec 30, 2015

The 'configurations' title at the top of the column. I don't think there's much use for it. configurations title

@tvdeyen
Copy link
Member

tvdeyen commented Dec 30, 2015

@Mandily ah yes, totally useless.

@Senjai
Copy link
Contributor

Senjai commented Dec 30, 2015

👍 🎉 🙌

@BenMorganIO
Copy link
Contributor

👍

@Dkendal
Copy link

Dkendal commented Jan 11, 2016

pretty!

@graygilmore graygilmore mentioned this issue Feb 17, 2016
5 tasks
@peterberkenbosch
Copy link
Contributor

🎉 👍

@Mandily
Copy link
Contributor Author

Mandily commented Apr 18, 2016

Tabs have been merged into the admin. They'll be included in the 1.3 release.

screen shot 2016-04-18 at 9 57 41 am

screen shot 2016-04-18 at 9 59 14 am

@Mandily Mandily closed this as completed Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants