Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication in API variants controller #2301

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Remove duplication in API variants controller #2301

merged 1 commit into from
Oct 20, 2017

Conversation

swcraig
Copy link
Contributor

@swcraig swcraig commented Oct 17, 2017 •
edited
Loading

These are equivalent.

jhawthorn
jhawthorn approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@jhawthorn jhawthorn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jhawthorn jhawthorn merged commit f137f97 into solidusio:master Oct 20, 2017
@swcraig swcraig deleted the remove-duplication-in-api-variants-controller branch October 20, 2017 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff approved these changes

@jhawthorn jhawthorn jhawthorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swcraig @jhawthorn @mamhoff