Rename subscription_order to installment_order

[aldesantis]

No description provided.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.

[chrean]

@aldesantis can you provide a bit of context on this? Seems like a fairly easy change that can help with code clarity, if I am not mistaken.

[nirebu]

@chrean I can provide more context here.

The meaning of the spree_orders.subscription_order column is to tell apart orders generated from a subscription (subscription_order: true) from orders generating subscriptions (subscription_order: false). A little bit of a tongue twister, but renaming it to installment_order would be more accurate because it's way clearer what it means.

This however feels like a breaking change.

[chrean]

Thanks for the context @nirebu : this confirms my feelings.
Probably not something we want to work on right away, but something to keep in mind for additional clarity on the code.