Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow three instead of two PIN retries per boot #35

Closed
robin-nitrokey opened this issue Jul 7, 2023 · 0 comments · Fixed by #36
Closed

Allow three instead of two PIN retries per boot #35

robin-nitrokey opened this issue Jul 7, 2023 · 0 comments · Fixed by #36

Comments

@robin-nitrokey
Copy link
Member

Currently, a PinAuthBlocked error is already returned after two wrong PIN entries. The reason for this is that decrement_retries also checks if the allowed retries are exceeded. This is unnecessary because pin_blocked is always checked before decrement_retries is called.
@robin-nitrokey robin-nitrokey mentioned this issue Jul 7, 2023
Closed
robin-nitrokey added a commit to robin-nitrokey/fido-authenticator that referenced this issue Jul 7, 2023
@robin-nitrokey
Allow three instead of two PIN retries per boot
6aa9fc4 
Previously, a PinAuthBlocked error was already returned after two wrong
PIN entries. The reason for this as that decrement_retries also checks
if the allowed retries are exceeded. This as unnecessary because
pin_blocked is always checked before decrement_retries is called.

This patch removes the check in decrement_retries.

Fixes: trussed-dev#35
@robin-nitrokey robin-nitrokey mentioned this issue Jul 7, 2023
Merged
robin-nitrokey added a commit to robin-nitrokey/fido-authenticator that referenced this issue Jul 10, 2023
@robin-nitrokey
Allow three instead of two PIN retries per boot
e96d54d 
Previously, a PinAuthBlocked error was already returned after two wrong
PIN entries. The reason for this as that decrement_retries also checks
if the allowed retries are exceeded. This as unnecessary because
pin_blocked is always checked before decrement_retries is called.

This patch removes the check in decrement_retries.

Fixes: trussed-dev#35
nickray pushed a commit to robin-nitrokey/fido-authenticator that referenced this issue Sep 13, 2023
@robin-nitrokey @nickray
Allow three instead of two PIN retries per boot
7a86e2f 
Previously, a PinAuthBlocked error was already returned after two wrong
PIN entries. The reason for this as that decrement_retries also checks
if the allowed retries are exceeded. This as unnecessary because
pin_blocked is always checked before decrement_retries is called.

This patch removes the check in decrement_retries.

Fixes: trussed-dev#35
nickray pushed a commit that referenced this issue Sep 13, 2023
@robin-nitrokey @nickray
Allow three instead of two PIN retries per boot
713c5e7 
Previously, a PinAuthBlocked error was already returned after two wrong
PIN entries. The reason for this as that decrement_retries also checks
if the allowed retries are exceeded. This as unnecessary because
pin_blocked is always checked before decrement_retries is called.

This patch removes the check in decrement_retries.

Fixes: #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow three instead of two PIN retries per boot robin-nitrokey/fido-authenticator
1 participant
@robin-nitrokey