Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded "\\a\\t" prevents translation file to use translation for "at" between the date and time in event popover #359

Closed
MvdO79 opened this issue Dec 20, 2024 · 2 comments · Fixed by #363
Assignees
Labels
issue Something isn't working correctly

Comments

@MvdO79
Copy link

MvdO79 commented Dec 20, 2024

Describe the bug or issue you're experiencing

Hardcoded "\a\t" prevents translation file to use translation for "at" between the date and time in event popover.

Steps to reproduce

Try to translate "at" in the translation file to another language. Check the event popover if "at" is translated to the desired language.

Expected behavior

If I translate "at" in another language I aspect to see that language in the event popover.

Craft & Plugin Info (please complete the following information):

Craft Version:
Pro 5.4.9
Calendar Version:
5.0.12
Calendar Edition:
Pro
Fresh Install or Upgrade:
Fresh

@MvdO79 MvdO79 added the issue Something isn't working correctly label Dec 20, 2024
@MvdO79
Copy link
Author

MvdO79 commented Dec 23, 2024

In the front end we have adjusted the code to work for us. But in the backend changes would be overwritten when updating the plugin. Thanks.

@kjmartens
Copy link
Contributor

Thanks @MvdO79,

We'll check into it and work on a fix for it. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue Something isn't working correctly
Development

Successfully merging a pull request may close this issue.

3 participants