-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preparation for multi device type support #307
preparation for multi device type support #307
Conversation
Hi @simon-schuster, Thank you very much for your pull request. I'm not feeling that comfortable with the changes. If we change the root device name and introducing folders, we will introduce a breaking change for everyone, where I don't see a big benefit. I prefer just introducing a new class for heating devices and keep the structure as is. Please also remove the new generic device, and simply use the new heating device. |
Hi @woehrl01, Thanks for taking the time to review. |
No, the idea is to just add the HeatingDevices, move the stuff from Device to the new HeatingDevice, and use the HeatingDevice as the generic device. |
@woehrl01 I have now reverted the folder structure to how it was before and move everything from device to heating device. |
@simon-schuster thank you. I left some comments, you can leave the changes if you make some additional ones 😊 |
Short explanation on what i did here:
PyViCareDevice
is now a base class for all different types of devicesPyViCareHeatingDevice
contains most of the functionality previously contained by thePyViCareDevice
PyViCareHeatingDevice
PyViCareDevice
PyViCareGenericDevice
is the new generic device which has to inherit all types of devices which will be added