Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Fail audit on IQ scan results failure #231

Open
KevinFauth opened this issue May 3, 2021 · 1 comment
Open

[FEATURE] Fail audit on IQ scan results failure #231

KevinFauth opened this issue May 3, 2021 · 1 comment

Comments

@KevinFauth
Copy link

  • What are you trying to do?
    I have items that are failing a scan, but the script is ignoring the failure.

Application.ts is calling auditResults.auditThirdPartyResults(results) https://github.com/sonatype-nexus-community/auditjs/blob/main/src/Application/Application.ts#L238
but the method returns true even though it's called out in a failure block: https://github.com/sonatype-nexus-community/auditjs/blob/main/src/Audit/AuditIQServer.ts#L27-L32

  Sonabot here, you have some build-breaking policy violations to clean up!
  Report URL: https://nexus...
  • What feature or behavior is this required for?
    Automated builds (Jenkins) are not seeing an exit 1 and therefore not failing.

  • How could we solve this issue? (Not knowing is okay!)
    I'm not sure who else is using this, so I hate to break everyone - maybe a command-line argument to double check the result in Application.ts?

  • Anything else?
    Keep up the good work - this project is saving me a lot of process and paperwork.. :-)

cc @bhamail / @DarthHater / @allenhsieh / @ken-duck

@DarthHater
Copy link
Member

This totally sounds like a bug! I'll take a gander.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants