Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle CWE name suffixed with 'noinfo' #129

Merged
merged 1 commit into from
May 25, 2023
Merged

fix: handle CWE name suffixed with 'noinfo' #129

merged 1 commit into from
May 25, 2023

Conversation

JimmyDore
Copy link
Contributor

@JimmyDore JimmyDore commented Feb 2, 2023 •
edited
Loading

Handles the case where CWE name == CWE-noinfo

It relates to the following issue :

cc @bhamail / @DarthHater

@JimmyDore JimmyDore mentioned this pull request Feb 2, 2023
Closed
@JimmyDore JimmyDore changed the title fix: handle CWE name suffixed with fix: handle CWE name suffixed with 'no-info' Feb 2, 2023
@JimmyDore JimmyDore changed the title fix: handle CWE name suffixed with 'no-info' fix: handle CWE name suffixed with 'noinfo' Feb 2, 2023
@iorlas
Copy link

iorlas commented Feb 7, 2023

Faced this issue just today. Push it please!

@JimmyDore
Copy link
Contributor Author

Hey ! 2 problems for this MR :

  • CI steps are failing, poetry seems having a hard time installing some external dependencies :
    image
  • Can't sign Sonatype CLA, as mentionned in Contributing.md, it seems the website url is not hosted anymore through heroku

@rbernalc
Copy link

This also fixed the issue for me. Thanks!

daviskirk
daviskirk suggested changes May 21, 2023
View reviewed changes
jake/command/oss.py Outdated Show resolved Hide resolved
bhamail
bhamail approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@bhamail bhamail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimmyDore @daviskirk
fix: handle CWE name suffixed with 'noinfo'
edfe36c 
@daviskirk suggestion

Co-authored-by: Davis Kirkendall <1049817+daviskirk@users.noreply.github.com>
@JimmyDore
Copy link
Contributor Author

@bhamail After fighting for verifying my commit, seems good to go. I guess you'll be the one managing the merge ?
image

@bhamail
Copy link
Contributor

bhamail commented May 25, 2023

@JimmyDore I'm planning to merge this now, however, I was hoping to get some other build issues fixed first. Unfortunately, the build issues are more complex than hoped, so after the merge, the release will likely fail. I don't expect to get time to look at it until next week, so please ping me if nothing happens after next week.

Thanks for the fix!

@bhamail bhamail merged commit a5d0f11 into sonatype-nexus-community:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviskirk daviskirk daviskirk requested changes

@bhamail bhamail bhamail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - "CWE-noinfo" not handled
5 participants
@JimmyDore @iorlas @rbernalc @bhamail @daviskirk