Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chassis-packet: pc_lag_2 test fails due to inclusion of internal portchannels #14436

Closed
anamehra opened this issue Mar 27, 2023 · 5 comments
Closed
Assignees
Labels
Chassis 🤖 Modular chassis support MSFT Triaged this issue has been triaged

Comments

@anamehra
Copy link
Contributor

Description

sonic-mgmt test pc/test_lag_2 is failing due to inclusion of back plane port channels in the test.

Looks like this happened after the following change to remove portchannel member array from config db
sonic-net/sonic-mgmt#7660
which was required due to this change:
#13660

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@anamehra
Copy link
Contributor Author

Hi @abdosi , raised this to track portchannel test case issue.

@rlhui
Copy link
Contributor

rlhui commented Mar 29, 2023

@abdosi will check more

@vmittal-msft vmittal-msft added MSFT Triaged this issue has been triaged labels Apr 12, 2023
@vmittal-msft vmittal-msft added the Chassis 🤖 Modular chassis support label Apr 12, 2023
@anamehra
Copy link
Contributor Author

There is a bug in sonic_py_common/multi_asic.py is_port_channel_internal function.
The function use PORTCHANNEL table to get member port and then test if member ports are internal.
With the new change in portchannel db, members is not an entry in PORTCHANNEL table in config db and thus the function always returns false and all portchannels are included in external list.

The fix is to use PORTCHANNEL_MEMBER table. I am testing a fix.

@anamehra
Copy link
Contributor Author

There is a PR in process for #14459 that should fix this issue as well.

@anamehra
Copy link
Contributor Author

Dup of #14459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chassis 🤖 Modular chassis support MSFT Triaged this issue has been triaged
Projects
None yet
Development

No branches or pull requests

4 participants