-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subinterface creation on Broadcom switches cause multiple container shutdown #18237
Comments
I am not able to open the log, please upload techsupport output |
@adyeung, I am adding the logs to the comment. logs
Also attaching the techsupport dump archive that was taken when containers exited after subinterface creation. |
Problem is specific to DellEMC-S5248f-P-25G, it appears the community DELL td3-s5248f-25g.config.bcm is missing SOC parameter flow_init_mode = 1 for VFI MGID creation, besides that there are other parameters also needed for VLAN VFI to work in TD3 for sub intf creation. Request DELL contributor @aravindmani-1 to help followup and update the file |
Thanks for the update, I noticed the same issue on |
@adyeung @aravindmani-1 is this fix going to get merged to the master? |
|
The same happens with
|
Hey @adyeung. perhaps you had a chance to take a look at |
@jostar-yang please help update the config.bcm files from Accton |
@jostar-yang have you had the opportunity to review this issue? |
@jostar-yang Hello, any update regarding this? |
@aravindmani-1 any news about this? |
@rlebedys did you test @aravindmani-1 fix, does it work for you? I've just tested it with s5248f and still, as soon as I add subinterface containers start to crash. The error:
the fix is applied:
|
@tomvil could you please share the complete steps that you tried?. |
@aravindmani-1 I have built the image (202405 branch) with your commit from #18505 pull request. I see the configuration is present in Is there anything else I can check for you? SAI version on my switch:
|
could you share the complete steps that you tried to recreate the issue(starting from the commands used)?. |
@aravindmani-1 here's how I reproduce the issue every time:
|
@tomvil can you upload the "show techsupport" logs(when you hit the issue, please collect logs since one hour using techsupport options)?. |
@aravindmani-1 here is techsupport logs that you asked from @tomvil |
SAI errors are observed and causing orchagent to crash.
@adyeung could you please check on why SAI failures are seen here?. |
Following attributes for router interface creation are not supported in the SAI version that is used by community SONiC: SAI_ROUTER_INTERFACE_ATTR_ADMIN_V4_STATE Please try commenting out the following in intfsorch.cpp and try: |
@aravindmani-1 @adyeung @anilkpan I found this TD3 configuration as possible fix:
tested with Dell and EdgeCore - both work as expected and subinterface doesn't cause crashes anymore. Can you advise if this is a good approach? found it in: #9491 |
@tomvil , let me check and get back on this. |
@tomvil , you are right, the router interface admin state support is actually merged to the SAI version linked to community. |
@anilkpan @aravindmani-1 will you merge these changes to master (and 202405 branch) ? |
Description
When creating a subinterface on Broadcom-based switches (Trident 3) it causes multiple containers to exit.
Steps to reproduce the issue:
config subinterface add EthernetXX.20 20
Describe the results you received:
Multiple containers (swss, syncd and others) exit and switch becomes unstable. Containers are in a crash loop.
Describe the results you expected:
Created subinterface on port EthernetXX.
Output of
show version
:Additional information you deem important (e.g. issue happens only occasionally):
Broadcom SAI version:
Attaching logs right after execution of
config subinterface add
command.subinterface_add_logs.txt
The text was updated successfully, but these errors were encountered: