Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate the tx buffer should be enough to gurantee pkts not drop at tx side #6173

Open
kevinskwang opened this issue Aug 16, 2022 · 1 comment · May be fixed by #14725
Open

Validate the tx buffer should be enough to gurantee pkts not drop at tx side #6173

kevinskwang opened this issue Aug 16, 2022 · 1 comment · May be fixed by #14725
Assignees
@developfast
Labels
QoS Test gap Triaged

Comments

@kevinskwang
Copy link
Collaborator

Description

All the admission control should be done at the ingress side. Tx side should guarantee those pkts could be all sent out.
Steps to reproduce the issue:
1.
2.
3.

Describe the results you received:

Describe the results you expected:

Additional information you deem important:

**Output of `show version`:**

```
(paste your output here)
```

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```
@lguohan
Copy link
Contributor

lguohan commented Aug 16, 2022

this should be applied to lossless traffic only, for lossy traffic tx drop is expected since there is no ingress admission control. but for lossless the admission control is at the ingress, there should be no admission control for the egress.

@yxieca yxieca added the Triaged label Sep 7, 2022
@yxieca yxieca added the QoS label Apr 5, 2023
@developfast developfast linked a pull request Sep 25, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@developfast developfast

Labels
QoS Test gap Triaged
Projects
None yet
Milestone
No milestone
4 participants
@lguohan @yxieca @developfast @kevinskwang