-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic_fw]: Add firmware management api base #30
Conversation
"module_name": "CPLD", | ||
"fw_version": { | ||
"CPLD1" : "1.0.0", | ||
"CPLD2" : "1.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case, i feel we should have CPLD1, CPLD2 as module name, each module will have only one version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case,the list of supported module will be ["BIOS", "CPLD1", "CPLD2"] instead of ["BIOS", "CPLD"] and get_fw_version function should return only version string
Is that good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update the comments?
@mudsut4ke: Is there any reason to keep this as a separate |
@jleveque , Maybe a reason that firmware install tool is installed in sonic platform and cannot be used on pmon docker |
@mudsut4ke: Can you elaborate? We would like to consolidate all platform-specific abstraction into the new If we were to install the |
@jleveque , In my case the CPLD upgrade tool installed in base image (sonic-net/sonic-buildimage#2446) if you install |
@jleveque , Any comment? |
I think it would be best to add this functionality to the ChassisBase and ModuleBase classes in the new platform API, and we can install the package in the base image as well as the pmon container. |
@mudsut4ke , any update on this? |
@mudsut4ke: I think adding the firmware management functions to |
Move to #34 |
Add base class for firmware management utillity (sonic-net/sonic-buildimage#2824)
Signed-off-by: Wirut Getbamrung wgetbumr@celestica.com