Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic_fw]: Add firmware management api base #30

Closed
wants to merge 1 commit into from

Conversation

mudsut4ke
Copy link
Contributor

Add base class for firmware management utillity (sonic-net/sonic-buildimage#2824)

Signed-off-by: Wirut Getbamrung wgetbumr@celestica.com

"module_name": "CPLD",
"fw_version": {
"CPLD1" : "1.0.0",
"CPLD2" : "1.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case, i feel we should have CPLD1, CPLD2 as module name, each module will have only one version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case,the list of supported module will be ["BIOS", "CPLD1", "CPLD2"] instead of ["BIOS", "CPLD"] and get_fw_version function should return only version string

Is that good?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the comments?

@jleveque
Copy link
Contributor

jleveque commented May 9, 2019

@mudsut4ke: Is there any reason to keep this as a separate sonic_fw package, or would be better to add get_fw_version() and install_firmware() methods to the ChassisBase and ModuleBase classes sonic_platform_base?

@mudsut4ke
Copy link
Contributor Author

@jleveque , Maybe a reason that firmware install tool is installed in sonic platform and cannot be used on pmon docker

@jleveque
Copy link
Contributor

jleveque commented May 13, 2019

@mudsut4ke: Can you elaborate? We would like to consolidate all platform-specific abstraction into the new sonic_platform_base package.

If we were to install the sonic_platform_base package in both the pmon docker and also in the base image, would this suffice?

@mudsut4ke
Copy link
Contributor Author

@jleveque , In my case the CPLD upgrade tool installed in base image (sonic-net/sonic-buildimage#2446)

if you install sonic_platform_base package in both the pmon docker and base image, that will cover my requirement

@mudsut4ke
Copy link
Contributor Author

@jleveque , Any comment?

@jleveque
Copy link
Contributor

I think it would be best to add this functionality to the ChassisBase and ModuleBase classes in the new platform API, and we can install the package in the base image as well as the pmon container.

@lguohan
Copy link
Contributor

lguohan commented Jun 6, 2019

@mudsut4ke , any update on this?

@mudsut4ke
Copy link
Contributor Author

@lguohan , I will move this tool to sonic_platform_base follow Joe suggesttion

@jleveque , In ChassisBase they Identified BIOS/FPGA/CPLD as component
Should I add new ComponentBase ? or Just add the firmware management to ModuleBase is enough ?

@jleveque
Copy link
Contributor

@mudsut4ke: I think adding the firmware management functions to ChassisBase and ModuleBase is enough.

@mudsut4ke
Copy link
Contributor Author

mudsut4ke commented Jun 14, 2019

Move to #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants