[dash] VNET mapping configuration is not processed correctly

[Yakiv-Huryk]

When processing the DASH_VNET_MAPPING_TABLE configuration, post logic (addVnetMapPost) is not executed. This leads to incorrect CRM logic and a lack of error checking.

The reason is that when both CAtoPA and PA Validation entries are added with no issues, the addVnetMap() returns true which leads to the task removal from m_toSync.

addOutboundCaToPa() returns true

sonic-swss/orchagent/dash/dashvnetorch.cpp

Lines 360 to 363 in 93f7c15

	object_statuses.emplace_back();
	outbound_ca_to_pa_bulker_.create_entry(&object_statuses.back(), &outbound_ca_to_pa_entry,
	(uint32_t)outbound_ca_to_pa_attrs.size(), outbound_ca_to_pa_attrs.data());
	return true;

addPaValidation() returns true

sonic-swss/orchagent/dash/dashvnetorch.cpp

Lines 401 to 404 in 93f7c15

	pa_refcount_table_[pa_ref_key] = 1;
	SWSS_LOG_INFO("Initialize PA refcount to 1 for PA IP %s",
	underlay_ip_str.c_str());
	return true;

addVnetMap() returns true

sonic-swss/orchagent/dash/dashvnetorch.cpp

Line 421 in 93f7c15

return addOutboundCaToPa(key, ctxt) && addPaValidation(key, ctxt);

doTaskVnetMapTable() erases the task

sonic-swss/orchagent/dash/dashvnetorch.cpp

Lines 737 to 740 in 93f7c15

	if (addVnetMap(key, ctxt))
	{
	it = consumer.m_toSync.erase(it);
	}

This is not executed since the task is no longer in the m_toSync

sonic-swss/orchagent/dash/dashvnetorch.cpp

Lines 767 to 791 in 93f7c15

	auto it_prev = consumer.m_toSync.begin();
	while (it_prev != it)
	{
	KeyOpFieldsValuesTuple t = it_prev->second;
	string key = kfvKey(t);
	string op = kfvOp(t);
	auto found = toBulk.find(make_pair(key, op));
	if (found == toBulk.end())
	{
	it_prev++;
	continue;
	}
	const auto& ctxt = found->second;
	const auto& outbound_ca_to_pa_object_statuses = ctxt.outbound_ca_to_pa_object_statuses;
	const auto& pa_validation_object_statuses = ctxt.pa_validation_object_statuses;
	if (outbound_ca_to_pa_object_statuses.empty() || pa_validation_object_statuses.empty())
	{
	it_prev++;
	continue;
	}
	if (op == SET_COMMAND)
	{
	if (addVnetMapPost(key, ctxt))