Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Bridge port remove error "None" #998

Open
antony-rheneus opened this issue Jul 29, 2019 · 4 comments
Open

Bug: Bridge port remove error "None" #998

antony-rheneus opened this issue Jul 29, 2019 · 4 comments

Comments

@antony-rheneus
Copy link
Contributor

https://github.com/Azure/sonic-swss/blob/ebb5324ddfdefd6ebcd38937856e5bebc7be4f60/cfgmgr/vlanmgr.cpp#L184

Bug: bridge vlan command doesn't print "None", so it will fail for VLan member ports as well non-Vlan member ports

There is NO 'None' printed in below bridge command
root@et6448m-M0:/home/admin# /sbin/bridge vlan show dev Ethernet17
port    vlan ids



root@et6448m-M0:/home/admin# config vlan member add 500 Ethernet17 -u
root@et6448m-M0:/home/admin# /sbin/bridge vlan show dev Ethernet17
port    vlan ids
Ethernet17       1 Egress Untagged
         500 PVID Egress Untagged

@stcheng
Copy link
Contributor

stcheng commented Jul 29, 2019

@jipanyang

@jipanyang
Copy link
Contributor

Looks like the same problem as sonic-net/sonic-buildimage#2658

Could take this fix:

 ''bridge vlan del vid 1 dev {{ port }}" should be called immediately after "ip link set dev {{ port }} master Bridge" the first time.

@antony-rheneus
Copy link
Contributor Author

Looks like the same problem as Azure/sonic-buildimage#2658

Could take this fix:

 ''bridge vlan del vid 1 dev {{ port }}" should be called immediately after "ip link set dev {{ port }} master Bridge" the first time.

I think right fix is to add Port_alias instead of None.
GREP_CMD + " -q " + port_alias "&& "

@jipanyang
Copy link
Contributor

root@ASW-A1-1.NA62:~# bridge vlan show dev PortChannel8
port	vlan ids
PortChannel8	 10 PVID Egress Untagged

Once a vlan member is out of default vlan 1, and is not in any other vlan .

root@ASW-A1-1.NA62:~# bridge vlan del vid 10 dev PortChannel8
root@ASW-A1-1.NA62:~# 
root@ASW-A1-1.NA62:~# bridge vlan show dev PortChannel8
port	vlan ids
PortChannel8	None

config vlan member del command has issue currently, it assumes the existence of members field in vlan table(sonic-net/SONiC#323). But the fix in #1001 is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants