Skip to content

Commit 6d507f5

Browse files
committed
remove __main__ construct
1 parent 40d3e52 commit 6d507f5

File tree

2 files changed

+7
-17
lines changed

2 files changed

+7
-17
lines changed

fdb_utils/filter_fdb_entries.py

+6-17
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
#!/usr/bin/env python
2-
31
import json
42
import sys
53
import os
@@ -130,38 +128,29 @@ def main(argv):
130128
parser.add_argument('-a', '--arp', type=str, default='/tmp/arp.json', help='arp file name')
131129
parser.add_argument('-c', '--config_db', type=str, default='/tmp/config_db.json', help='config db file name')
132130
parser.add_argument('-b', '--backup_file', type=bool, default=True, help='Back up old fdb entries file')
133-
args = parser.parse_args(argv)
131+
args = parser.parse_args(argv[1:])
134132

135133
fdb_filename = args.fdb
136134
arp_filename = args.arp
137135
config_db_filename = args.config_db
138136
backup_file = args.backup_file
139137

140138
try:
139+
syslog.openlog('filter_fdb_entries')
141140
file_exists_or_raise(fdb_filename)
142141
file_exists_or_raise(arp_filename)
143142
file_exists_or_raise(config_db_filename)
144143
except Exception as e:
145144
syslog.syslog(syslog.LOG_ERR, "Got an exception %s: Traceback: %s" % (str(e), traceback.format_exc()))
146-
else:
147-
filter_fdb_entries(fdb_filename, arp_filename, config_db_filename, backup_file)
148-
149-
return 0
150-
151-
if __name__ == '__main__':
152-
res = 0
153-
try:
154-
syslog.openlog('filter_fdb_entries')
155-
res = main(sys.argv[1:])
156145
except KeyboardInterrupt:
157146
syslog.syslog(syslog.LOG_NOTICE, "SIGINT received. Quitting")
158147
res = 1
159148
except Exception as e:
160149
syslog.syslog(syslog.LOG_ERR, "Got an exception %s: Traceback: %s" % (str(e), traceback.format_exc()))
161150
res = 2
151+
else:
152+
filter_fdb_entries(fdb_filename, arp_filename, config_db_filename, backup_file)
162153
finally:
163154
syslog.closelog()
164-
try:
165-
sys.exit(res)
166-
except SystemExit:
167-
os._exit(res)
155+
156+
return 0

tests/filter_fdb_entries_test.py

+1
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ def testFilterFdbEntries(self, testData):
164164
try:
165165
self.__setUp(testData)
166166
argv = [
167+
"filter_fdb_entries",
167168
"-a",
168169
self.ARP_FILENAME,
169170
"-f",

0 commit comments

Comments
 (0)