Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic_installer] should not return fail (rc=1) if new image is the same as what has been installed #200

Closed
maggiemsft opened this issue Feb 12, 2018 · 1 comment
Assignees

Comments

@maggiemsft
Copy link

sonic_installer return 1 if the upgrade new image is the same as what has been installed

Steps to reproduce the issue

  1. use sonic_installer to upgrade SONiC to same image version

Describe the results you received
shell returns 1 which indicate fail

Describe the results you expected
could it exit with success while do not do "reinstall"?

Additional information you deem important (e.g. issue happens only occasionally)

Output of show version

(paste your output here)
@jleveque
Copy link
Contributor

Root cause of nonzero exit code is in sonic-buildimage/installer/x86_64/install.sh.

PR to fix this is at: sonic-net/sonic-buildimage#1389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants