Fix linux build and QT Deprecations (#3305)

* set gcc12 as the default compiler for linux

* update documentation to include info about gcc12 for building with linux

* update .gitignore to ignore build artefacts

* Include QTQuick in the build

* fix unsued return value error while loading qt translations

* fix rb_data_object_allow deprecation

* fix deprecation warning for QApplication::setActiveWindow(QWidget*)

* Do not set default attributes

* Revert "Include QTQuick in the build"

This reverts commit 4280ab4.

* Spider - update active support to 7.0.6

Switches transient gems - thread_safe and atomic are replaced with concurrent_ruby. tzinfo is also pulled in.

* Spider - improve runtime error reporting

Recent Ruby versions introduced a detailed_message method to Exception which includes the useful "did you mean" information which was dropped from the message method.

* delete atomic_reference.c

---------

Co-authored-by: Liam <lgh@e.email>
Co-authored-by: Sam Aaron <samaaron@gmail.com>

Author: contra-bit

.gitignore

@@ -154,3 +154,5 @@ etc/synthdefs/designs/overtone/sonic-pi/native
 
 # Visual Studio settings folder.
 .vs
+app/.cache/clangd/index
+sonic-pi.desktop

BUILD-LINUX.md

@@ -47,13 +47,15 @@ and to run
 In order to build Sonic Pi's various components, we need to install a
 few dependencies:
 
-* Build Tools (c++ compiler, cmake, git.)
+* Build Tools (c++ compiler , cmake, git.)
 * Qt + Dev tools (5.15+)
 * Jack (and pulse-audio-module-jack if you are running Raspberry Pi OS)
 * Ruby + Dev tools (2.5+)
 * Elixir + Dev tools (12.0+)
 * SuperCollider + SC3 plugins
 
+Note: please make sure that you have gcc12 installed. Compiling vcpkg dependencies does not work with gcc13 currently
+
 
 ### 1.1 Debian
 The following is a rough list of Debian packages that are needed that can serve as a starting position:

app/gui/qt/main.cpp

@@ -57,8 +57,6 @@ int main(int argc, char *argv[])
 
 #if defined(Q_OS_LINUX)
   //linux code goes here
-  QApplication::setAttribute(Qt::AA_UseHighDpiPixmaps);
-  QApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
 #elif defined(Q_OS_WIN)
   // windows code goes here
 

app/gui/qt/mainwindow.cpp

@@ -270,7 +270,8 @@ MainWindow::MainWindow(QApplication& app, QSplashScreen* splash)
 
     toggleOSCServer(1);
 
-    app.setActiveWindow(editorTabWidget->currentWidget());
+    editorTabWidget->currentWidget()->activateWindow();
+
 
     showWelcomeScreen();
 

app/gui/qt/utils/sonicpi_i18n.cpp

@@ -111,13 +111,15 @@ bool SonicPii18n::loadTranslations(QString lang) {
   std::cout << "[GUI] [i18n] - Loading translations for " << language.toUtf8().constData() << std::endl;
 
   i18n = translator.load("sonic-pi_" + language, ":/lang/") || language == "en_GB" || language == "en" || language == "C";
-  if (!i18n) {
-    std::cout << "[GUI] [i18n] - Error: Failed to load language translation for " << language.toUtf8().constData() << std::endl;
-    language = "en_GB";
-  }
-  app->installTranslator(&translator);
+    i18n = translator.load("sonic-pi_" + language, ":/lang/") || language == "en_GB" || language == "en" || language == "C";
+    bool translator_succes_qt = qtTranslator.load("qt_" + language, QLibraryInfo::path(QLibraryInfo::TranslationsPath));
+    if (!i18n || !translator_succes_qt)
+    {
+        std::cout << "[GUI] [i18n] - Error: Failed to load language translation for " << language.toUtf8().constData() << std::endl;
+        language = "en_GB";
+    }
+    app->installTranslator(&translator);
 
-  qtTranslator.load("qt_" + language, QLibraryInfo::location(QLibraryInfo::TranslationsPath));
   app->installTranslator(&qtTranslator);
 
   this->currently_loaded_language = language;

app/linux-prebuild.sh

@@ -28,6 +28,8 @@ cd "${SCRIPT_DIR}"
 
 if [ ! "$system_libs" == true ]; then
   "${SCRIPT_DIR}"/linux-pre-vcpkg.sh "${args[@]}"
+	export CC=gcc-12 CXX=g++-12 # Use gcc-12 as the default compiler, since gcc-13 fails to build vcpkg
+	"${SCRIPT_DIR}"/linux-pre-vcpkg.sh "${args[@]}"
 fi
 
 echo "Compiling native ruby extensions..."